This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Unix support for connecting to appservice #16425
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to fancy, shouldn't need any configuration changes on either end(I think).
I think the only thing of note is that for forming a request URI with a
unix://
scheme, a:
is appended to the end of the filename of the socket, to allow parsing out where the filename ends and the URL path begins(very similar to how Nginx does it). So:unix:/path/to.socket
with a request to/_matrix/app/v1/ping
internally as it's passed into the request function will look like:
unix:/path/to.socket:/_matrix/app/v1/ping
.Additionally, as a sanity check, the scheme can have multiple
/
between theunix:
and the path to the socket file, as I've encountered multiple variants over the years(and there seems to be no real standard). So that means that if any of these will be stripped to a single/
and look like the first item below:unix:/path/to.socket
unix://path/to.socket
unix:///path/to.socket
Pull Request Checklist
(run the linters)
Signed-off-by: Jason Little [email protected]